Skip to content

docs(faq.md): add instructions to flash built firmware#2248

Open
arthurlutz wants to merge 2 commits intomeshcore-dev:mainfrom
arthurlutz:patch-1
Open

docs(faq.md): add instructions to flash built firmware#2248
arthurlutz wants to merge 2 commits intomeshcore-dev:mainfrom
arthurlutz:patch-1

Conversation

@arthurlutz
Copy link
Copy Markdown

No description provided.

Copy link
Copy Markdown
Contributor

@LitBomb LitBomb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for your PR.

you numbered your addition as 5.9.2. But the one before it is 5.9., not 5.9.1. Also, you did not update the table of content at the very top of the FAQ.

Would be great if you could make these changes.

@arthurlutz
Copy link
Copy Markdown
Author

done

Copy link
Copy Markdown
Contributor

@LitBomb LitBomb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am sorry, please use 3.9. as an example. The convention is:

3.8.
3.9.
3.9.1.
3.9.2.

so, to add a new sub header after 5.9, it should be:

5.9.
5.9.1.

the table of content is generated with Markdown All in One Visual Studio plugin and this is the convention it uses. It would take care of the numbering automatic. But for hand edit, please follow the example above.

If you want I can take care of it with a separate PR. Thanks.

@arthurlutz
Copy link
Copy Markdown
Author

Feel free to edit the PR or fix the content of the initial PR, that seems to be an easier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants